Add support for architecture selection during updating of buildpack dependencies #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependencies Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
type:bug
Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added a commit
to paketo-buildpacks/libpak-tools
that referenced
this pull request
Nov 9, 2024
Signed-off-by: Daniel Mikusa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
update-buildpack-dependencytoo doesn't match correctly with the introduction of dependency architectures. This includes architecture as a consideration when filtering the dependencies to pick what is updated. A dependency now needs to match both the ID and ARCH.This is presently pulling the architecture from the PURL as it's the only currently reliable spot to get it. In the future, when all of the buildpacks have switched to it, we should pull from the arch field.
Use Cases
Multi-arch support.
Checklist